-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add wrench icon #121
base: main
Are you sure you want to change the base?
Conversation
add really big dashboard covering about 70-80% of all elements used or described. update news file as I believe version update to AdminLTE 2.3.2 is fine and not going to break anything.
add news and update descripition.
delete `interactive()` because tests are in Rignore add comments fix tabItems issue comment repro issues fix version, bump both package further ahead and make sure that rstudio#42 is not repro on my pc
and delete 117 test.
delete Rcpp from travis add 2 new repro cases for new issues
@@ -250,7 +251,7 @@ infoBox <- function(title, value = NULL, subtitle = NULL, | |||
#' @export | |||
box <- function(..., title = NULL, footer = NULL, status = NULL, | |||
solidHeader = FALSE, background = NULL, width = 6, | |||
height = NULL, collapsible = FALSE, collapsed = FALSE) { | |||
height = NULL, collapsible = FALSE, collapsed = FALSE, wrench = FALSE) { | |||
|
|||
boxClass <- "box" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After deep thinking:
Not so much sure if wrench=
should be boolean. Rather something like tags$li =
....
EDIT:see below
Hi @wch , I know that this project is not 100% priority nowadays - but I want to get a new version (with some of my changes) to CRAN so that many users could benefit from it. |
137576c
to
13ff71f
Compare
So I guess it will be easier for you just to follow this:http://stackoverflow.com/a/5309051 Basically, you would (not tested)
which would merge all my commits (from here) into one commit OR basically https://github.com/blog/2141-squash-your-commits |
It would be more consistent to implement this with something similar to the existing menus (message, notification, task). Instead of allowing users to pass in any content, it should be something like: boxMenu(icon = shiny::icon("wrench"),
item(text = "text")
) This is only a rough idea though -- since the HTML is quite a bit different from the other Then the Also, the menu should be able to be made dynamic, similar to various menus documented in the shinydashboard website. An approach like this will be good for maintainability in the future. |
|
The interface for For example, there's a |
headerTag <- NULL | ||
if (!is.null(titleTag) || !is.null(collapseTag)) { | ||
if (!is.null(titleTag) || !is.null(boxTools)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't boxTools
always be non-NULL? I think the boxTools
div should be created only if it's needed.
Yes, it is different. The reason is also that it can contain anything, from a download button to print-this-image links etc. Giving users only |
Something like this ?
I find such a split quite unnecessary, don't you too ? |
|
According to the requiest here: #92 The user would like to see a 🔧 icon. I think - for me - this is pretty possible to accomplish.
However, i have yet to come up with the way of how to display the dropdown menu.
EDIT: maybe something like re-using
dropdownMenu
and extend it somewhat? See also old comments.🆙 This also deletes Rcpp which is no longer necessary.